Emmanuele Bassi [Mon, 7 Dec 2020 15:23:55 +0000 (15:23 +0000)]
Merge branch 'ebassi/activate-signal' into 'master'
Add accessors for GtkWidgetClass.activate_signal
See merge request GNOME/gtk!2925
Jakub Steiner [Mon, 7 Dec 2020 09:58:12 +0000 (10:58 +0100)]
Revert "Adwaita: avoid clipping menu shadows"
While the workaround hides majority of the issue there are still two big downsides:
- shadow does eat from the widget dimensions so alignment is broken
- situations like popover going upwards on screen edge break completely
The appropriate action is to revert these theme duct tape solutions to make room
for a proper fix.
This reverts commit
b3dba1dca66d380d1cfafbe92b36d7854b3f4244.
Issue https://gitlab.gnome.org/GNOME/gtk/-/issues/1987
Emmanuele Bassi [Mon, 7 Dec 2020 00:26:50 +0000 (00:26 +0000)]
Merge branch 'wayland-inhbit0' into 'master'
wayland: avoid referencing unallocated memory when uninhibiting
See merge request GNOME/gtk!2927
Michael Terry [Sun, 6 Dec 2020 23:36:58 +0000 (18:36 -0500)]
wayland: avoid referencing unallocated memory when uninhibiting
Zander Brown [Sun, 6 Dec 2020 22:08:30 +0000 (22:08 +0000)]
Update British English translation
Emmanuele Bassi [Sun, 6 Dec 2020 15:13:57 +0000 (15:13 +0000)]
docs: Clarify gtk_widget_activate()
We need to tell people what signal will be emitted when calling
gtk_widget_activate(), and that the shortcuts API might be more
appropriate to what they are looking for.
Emmanuele Bassi [Sun, 6 Dec 2020 15:06:18 +0000 (15:06 +0000)]
Move activate_signal to the widget private class data
Instead of having it as a field in the class structure.
Emmanuele Bassi [Sat, 5 Dec 2020 20:52:04 +0000 (20:52 +0000)]
Merge branch 'ebassi/a11y-leak' into 'master'
a11y: Plug a leak in the AT-SPI context
Closes #3450
See merge request GNOME/gtk!2926
Emmanuele Bassi [Sat, 5 Dec 2020 20:25:30 +0000 (20:25 +0000)]
a11y: Plug a leak in the AT-SPI context
Fixes: #3450
Matthias Clasen [Sat, 5 Dec 2020 16:34:52 +0000 (11:34 -0500)]
Update contribution guide
Make my feelings about bug reporting by screencast known.
Matthias Clasen [Sat, 5 Dec 2020 15:10:16 +0000 (15:10 +0000)]
Merge branch 'revert-round-windows' into 'master'
Revert "theme: Round all window corners"
See merge request GNOME/gtk!2921
Piotr Drąg [Sat, 5 Dec 2020 14:05:48 +0000 (15:05 +0100)]
Update POTFILES.in
Emmanuele Bassi [Sat, 5 Dec 2020 01:03:00 +0000 (01:03 +0000)]
Use WidgetClass.activate_signal getter function
Emmanuele Bassi [Sat, 5 Dec 2020 00:59:55 +0000 (00:59 +0000)]
Add getter for WidgetClass.activate_signal
Just like we have a setter.
Emmanuele Bassi [Fri, 4 Dec 2020 23:12:50 +0000 (23:12 +0000)]
Use private can_activate() method
Instead of checking the activate_signal field directly.
Emmanuele Bassi [Fri, 4 Dec 2020 23:12:20 +0000 (23:12 +0000)]
Use function setter for WidgetClass.activate_signal
Emmanuele Bassi [Fri, 4 Dec 2020 23:01:57 +0000 (23:01 +0000)]
Add private method to check activatability
We should have an actual method, instead of checking the
WidgetClass.activate_signal directly.
Emmanuele Bassi [Fri, 4 Dec 2020 17:01:23 +0000 (17:01 +0000)]
Add wrappers for setting the WidgetClass.activate_signal field
Setting a field on a class structure is not always an easy task from
languages other than C. While bindings can provide access to the class
pointer, twiddling the fields in the class structure can be awkward.
Additionally, signal ids are not always readily available.
We can paper over the direct access to the class structure, as well as
the "signal name to id" mapping with a simple couple of setter
functions.
Emmanuele Bassi [Fri, 4 Dec 2020 23:39:48 +0000 (23:39 +0000)]
Merge branch 'wip/jfelder/customsorter-null' into 'master'
customsorter: Add missing nullable annotation
See merge request GNOME/gtk!2923
Jean Felder [Fri, 4 Dec 2020 23:04:36 +0000 (00:04 +0100)]
customsorter: Add missing nullable annotation
Emmanuele Bassi [Fri, 4 Dec 2020 22:37:00 +0000 (22:37 +0000)]
Merge branch 'wip/chergert/gdk-macos-for-master' into 'master'
macos: fix GL renderer for macOS
Closes #3420
See merge request GNOME/gtk!2922
Christian Hergert [Fri, 4 Dec 2020 21:41:31 +0000 (13:41 -0800)]
macos: enable GL renderer by default
Now that the attribute locations are fixed for the GL renderer, we can
enable it by default on macOS.
Fixes #3420
Christian Hergert [Fri, 4 Dec 2020 21:33:34 +0000 (13:33 -0800)]
gl: specify attribute locations for vUv and aPosition
These positions are not guaranteed to be in a specific order when linked
into the final GPU program. They need to be specified so that our code
in gskglrenderer.c can use known positions for them to match up with
our GskQuadVertex.
This fixes the GL renderer on macOS's OpenGL shader compiler.
Fixes #3420
Matthias Clasen [Fri, 4 Dec 2020 17:21:56 +0000 (17:21 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
emoji chooser: Fix incremental loading
Closes #3438
See merge request GNOME/gtk!2920
Matthias Clasen [Fri, 4 Dec 2020 16:39:13 +0000 (11:39 -0500)]
docs: Fix up GtkPicture docs
These were missing proper linking.
Matthias Clasen [Fri, 4 Dec 2020 16:13:26 +0000 (11:13 -0500)]
Revert "theme: Round all window corners"
This reverts commit
e46522e4b522aa163ca757436dc948b1d989530d.
Matthias Clasen [Fri, 4 Dec 2020 15:58:24 +0000 (10:58 -0500)]
emoji chooser: Fix incremental loading
This broke when we started using GDK_PROFILER_CURRENT_TIME for
timekeeping - that gets defined to 0 when we're building without
sysprof, so we can use it to make such determinations. Go back
to using g_get_monotonic_time().
Fixes: #3438
Matthias Clasen [Fri, 4 Dec 2020 04:12:41 +0000 (04:12 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2918
Matthias Clasen [Fri, 4 Dec 2020 03:31:05 +0000 (22:31 -0500)]
gtk-demo: Use a native filechooser in the words demo
Benjamin Otte [Fri, 4 Dec 2020 02:04:19 +0000 (02:04 +0000)]
Merge branch 'picture-docs2' into 'master'
Add docs about sizing pictures
See merge request GNOME/gtk!2917
Benjamin Otte [Fri, 4 Dec 2020 02:04:19 +0000 (02:04 +0000)]
Add docs about sizing pictures
Suggested by Christopher Davis.
Matthias Clasen [Fri, 4 Dec 2020 00:44:45 +0000 (19:44 -0500)]
gtk-demo: Use a native file chooser in the svg demo
Matthias Clasen [Fri, 4 Dec 2020 00:36:53 +0000 (19:36 -0500)]
gtk-demo: Use a native filechooser in the video demo
Matthias Clasen [Fri, 4 Dec 2020 00:24:19 +0000 (19:24 -0500)]
gtk-demo: Remove empty row in the pickers demo
The file chooser button is gone.
Emmanuele Bassi [Thu, 3 Dec 2020 22:54:46 +0000 (22:54 +0000)]
Merge branch 'wip/chergert/macos-decelerate' into 'master'
macos: fix typo when creating scroll events
Closes #3418
See merge request GNOME/gtk!2916
Christian Hergert [Thu, 3 Dec 2020 21:44:14 +0000 (13:44 -0800)]
macos: fix typo when creating scroll events
This fixes an issue where we would ignore events with Y delta
and no X delta while scrolling due to a typo when checking for
any delta.
This fixes deceleration of kinetic scrolling on the macOS backend.
Fixes #3418
Matthias Clasen [Thu, 3 Dec 2020 20:07:16 +0000 (20:07 +0000)]
Merge branch 'wip/chergert/gdk-macos-for-master' into 'master'
macos: fix motion event delivery after closing transient window
Closes #3419
See merge request GNOME/gtk!2910
Matthias Clasen [Thu, 3 Dec 2020 19:00:39 +0000 (19:00 +0000)]
Merge branch 'wip/chergert/shadertoy-macos-fix' into 'master'
demos: make alienplanet demo work on macOS OpenGL
See merge request GNOME/gtk!2915
Christian Hergert [Thu, 3 Dec 2020 18:20:11 +0000 (10:20 -0800)]
demos: make alienplanet demo work on macOS OpenGL
On the macOS OpenGL implementation, the use of noise2 as a
function within the glsl shader collides with the builtin noise2 of a
different signature.
This changes the name to something similar (noize2) so that we
do not risk colliding names when linking.
With this commit, the shadertoy alienplanet demo works on mac
OpenGL (albeit still with the Cairo renderer).
Matthias Clasen [Thu, 3 Dec 2020 17:14:01 +0000 (17:14 +0000)]
Merge branch 'wip/otte/conic' into 'master'
Implement a GL shader for conic gradients
See merge request GNOME/gtk!2913
Emmanuele Bassi [Thu, 3 Dec 2020 12:32:24 +0000 (12:32 +0000)]
Merge branch 'wip/tintou/gdk-backends-header' into 'master'
build: Use the correct path to the header of the wayland and x11 backends
See merge request GNOME/gtk!2914
Benjamin Otte [Thu, 3 Dec 2020 05:02:18 +0000 (06:02 +0100)]
glrenderer: Implement a shader for conic gradients
Benjamin Otte [Thu, 3 Dec 2020 05:00:21 +0000 (06:00 +0100)]
rendernode: Fix some wrong constants for conic gradients
copy/paste from other nodes left some wrong values in there and that
screwed things up quite a bit.
Benjamin Otte [Thu, 3 Dec 2020 04:33:30 +0000 (05:33 +0100)]
glrenderer: Emit more useful error messages
Catch the error when it happens, so that we can emit a specific and more
helpful error message.
Also verify that all branches in the code now do indeed set a proper
GError when they fail, so that the final catch-all is no longer needed.
Instead, assert that the error is set so that we catch future code
additions early that do not set the GError.
Corentin Noël [Thu, 3 Dec 2020 09:02:03 +0000 (10:02 +0100)]
build: Use the correct path to the header of the wayland and x11 backends
Matthias Clasen [Thu, 3 Dec 2020 04:10:39 +0000 (23:10 -0500)]
NEWS: Updates
Matthias Clasen [Thu, 3 Dec 2020 03:54:24 +0000 (03:54 +0000)]
Merge branch 'wip/otte/conic' into 'master'
Add support for conic gradients
See merge request GNOME/gtk!2911
Christian Hergert [Thu, 3 Dec 2020 03:42:07 +0000 (19:42 -0800)]
macos: plug leak of application windows
This ensures that we don't leak window references inside the action muxer.
Otherwise, we risk not disposing the windows upon gtk_window_destroy()
and blocking the main loop from quitting.
Fixes #3419
Christian Hergert [Thu, 3 Dec 2020 03:41:16 +0000 (19:41 -0800)]
muxer: add helper to get group by name
This is useful when you need to read a group back out of the muxer.
Christian Hergert [Thu, 3 Dec 2020 00:53:05 +0000 (16:53 -0800)]
macos: ensure element is part of queue
We don't want to risk decrementing length field unless this is actually
part of the queue.
Christian Hergert [Thu, 3 Dec 2020 00:51:31 +0000 (16:51 -0800)]
macos: maintain GList element consistency
We need to keep this consistent so that we can look things up
faster in other places. Therefore, just take the hit here and clear
the entire list ensuring prev/next poniters are cleared.
Christian Hergert [Wed, 2 Dec 2020 21:44:23 +0000 (13:44 -0800)]
macos: send focus-out event to windowing
Christian Hergert [Wed, 2 Dec 2020 21:10:23 +0000 (13:10 -0800)]
macos: freeze updates until surface is mapped
This more closely matches the X11 backend in terms of freezing
updates on the surface initially until we get mapped.
Matthias Clasen [Thu, 3 Dec 2020 03:43:19 +0000 (03:43 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
Closes #3429
See merge request GNOME/gtk!2912
Benjamin Otte [Thu, 3 Dec 2020 00:24:45 +0000 (01:24 +0100)]
css: Add support for conic-gradient()
This comes complete with animation support. For a good time, try:
@keyframes conic {
100% { background-image: conic-gradient(from 1turn, red, lime, blue, yellow, red); }
}
window {
background-image: conic-gradient(red, lime, blue, yellow, red);
animation: conic infinite linear 5s;
}
Benjamin Otte [Thu, 3 Dec 2020 01:31:39 +0000 (01:31 +0000)]
Merge branch 'wip/otte/diediedie' into 'master'
Remove GtkFileChooserButton
See merge request GNOME/gtk!2909
Benjamin Otte [Wed, 2 Dec 2020 19:15:28 +0000 (20:15 +0100)]
gtk: Remove GtkFileChooserButton
... as discussed in the meeting.
Matthias Clasen [Thu, 3 Dec 2020 00:59:44 +0000 (19:59 -0500)]
docs: Remove mentions of <accelerator>
That is no longer supported, keyboard shortcuts
are done with GtkShortcut now.
Fixes: #3429
Matthias Clasen [Thu, 3 Dec 2020 00:53:55 +0000 (19:53 -0500)]
gtk-demo: Add a search button
Easter eggs are great, but search shouldn't be one.
Benjamin Otte [Thu, 3 Dec 2020 00:15:53 +0000 (01:15 +0100)]
snapshot: Add gsk_snapshot_append_conic_gradient()
Benjamin Otte [Wed, 2 Dec 2020 23:47:54 +0000 (00:47 +0100)]
gsk: Add GskConicGradientNode
Matthias Clasen [Wed, 2 Dec 2020 22:14:27 +0000 (22:14 +0000)]
Merge branch 'fix/keyboard-input' into 'master'
Gdk4/Win32: Correct calls to gdk_key_event_new()
See merge request GNOME/gtk!2903
Matthew Jakeman [Wed, 2 Dec 2020 22:14:27 +0000 (22:14 +0000)]
Gdk4/Win32: Correct call to gdk_key_event_new()
The keycode and modifier (state) parameters are in the wrong order
for gdk_key_event_new() in the gdk win32 backend, which causes
key up/down events to be populated incorrectly.
Benjamin Otte [Wed, 2 Dec 2020 20:48:35 +0000 (21:48 +0100)]
rendernodeparser: Split out a function
Matthias Clasen [Wed, 2 Dec 2020 20:15:51 +0000 (20:15 +0000)]
Merge branch 'wip/chergert/gdk-macos-for-master' into 'master'
Revert "macos: specify a window level for surfaces"
See merge request GNOME/gtk!2908
Emmanuele Bassi [Wed, 2 Dec 2020 20:08:05 +0000 (20:08 +0000)]
Merge branch 'ebassi/doc-fixes' into 'master'
Ebassi/doc fixes
Closes #3428
See merge request GNOME/gtk!2906
Christian Hergert [Wed, 2 Dec 2020 19:35:22 +0000 (11:35 -0800)]
macos: resign main/key when hiding window
This isn't done automatically for us, so we need to synthesize it in
our hide helper.
With this commit, we properly re-focus the new main/key window after
we have closed a transient-for window.
Christian Hergert [Wed, 2 Dec 2020 19:35:02 +0000 (11:35 -0800)]
macos: disconnect frame clock when destroying surface
Christian Hergert [Wed, 2 Dec 2020 19:34:31 +0000 (11:34 -0800)]
macos: track grab serial like other backends
This is what is done elsewhere, so copy that here too now that we actually
generate serials for events.
Benjamin Otte [Wed, 2 Dec 2020 18:48:15 +0000 (19:48 +0100)]
tests: Remove testsvg
That demo lives in gtk-demo now.
Christian Hergert [Wed, 2 Dec 2020 19:15:57 +0000 (11:15 -0800)]
Revert "macos: specify a window level for surfaces"
This reverts commit
ca8b00e87192570541e33c9320167b1146457210.
This isn't needed and causes issues with other applications getting
stacked beneath our windows.
Emmanuele Bassi [Wed, 2 Dec 2020 19:09:10 +0000 (19:09 +0000)]
Fix transfer of GtkTreeExpander.get_item()
We return a full reference to the item.
Fixes: #3428
Emmanuele Bassi [Wed, 2 Dec 2020 19:04:43 +0000 (19:04 +0000)]
docs: Add missing fields to GtkTextBufferClass
Emmanuele Bassi [Wed, 2 Dec 2020 18:53:45 +0000 (18:53 +0000)]
docs: Hide private files/directories in the GTK reference
Emmanuele Bassi [Wed, 2 Dec 2020 18:53:17 +0000 (18:53 +0000)]
docs: Mark GtkModelButton's section as private
The widget is not public any more.
Emmanuele Bassi [Wed, 2 Dec 2020 15:48:31 +0000 (15:48 +0000)]
docs: Add more symbols to the GDK reference
Emmanuele Bassi [Wed, 2 Dec 2020 15:48:17 +0000 (15:48 +0000)]
docs: Add yet another private header
Emmanuele Bassi [Wed, 2 Dec 2020 15:25:05 +0000 (15:25 +0000)]
docs: More ignored files
Emmanuele Bassi [Wed, 2 Dec 2020 15:24:51 +0000 (15:24 +0000)]
docs: Remove duplicate symbol
Emmanuele Bassi [Wed, 2 Dec 2020 15:15:30 +0000 (15:15 +0000)]
docs: Add missing GdkDragSurfaceInterface gtk-doc annotation
Emmanuele Bassi [Wed, 2 Dec 2020 15:10:54 +0000 (15:10 +0000)]
docs: Ignore harder
First of all, we must list *all* ignored headers. Since we have public
headers in the x11 and wayland directories, we must explicitly declare
all headers that we consider private under those directories.
The "quartz" subdirectory was renamed "macos", with the new macOS
backend. The "mir" directory was removed, so there's no need to ignore
it.
We are also missing a bunch of ignored headers in the top-level gdk
directory.
Finally, pass the list of ignored files to gtkdoc-mkdb, so we won't get
missing declaration warnings.
Emmanuele Bassi [Wed, 2 Dec 2020 15:10:25 +0000 (15:10 +0000)]
docs: Remove private symbols from the API reference
Emmanuele Bassi [Wed, 2 Dec 2020 15:09:32 +0000 (15:09 +0000)]
Remove gtk-doc annotation from private symbols
Keep the documentation, just tweak it so that gtk-doc won't try to find
the declarations of these private symbols.
Matthias Clasen [Wed, 2 Dec 2020 18:38:14 +0000 (18:38 +0000)]
Merge branch 'wip/chergert/gdk-macos-for-master' into 'master'
macos: fix window stacking
See merge request GNOME/gtk!2907
Christian Hergert [Wed, 2 Dec 2020 18:20:07 +0000 (10:20 -0800)]
macos: place above transient-for when presenting
We need to re-attach to the transient-for window whenever we present or
we risk getting placed behind the window by the display server. Apparently
that setting does not persist across a hide of the NSWindow.
Christian Hergert [Wed, 2 Dec 2020 18:15:43 +0000 (10:15 -0800)]
macos: specify a window level for surfaces
Matthias Clasen [Wed, 2 Dec 2020 15:57:39 +0000 (15:57 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2905
Bilal Elmoussaoui [Tue, 24 Nov 2020 20:41:18 +0000 (21:41 +0100)]
StringList: add missing nullability annotations
Bilal Elmoussaoui [Tue, 24 Nov 2020 17:32:48 +0000 (18:32 +0100)]
Shortcut: add missing nullability annotations
Bilal Elmoussaoui [Tue, 24 Nov 2020 17:18:47 +0000 (18:18 +0100)]
StringFilter: get_search fix nullable annotation
Bilal Elmoussaoui [Tue, 24 Nov 2020 17:15:38 +0000 (18:15 +0100)]
Text: add missing nullability annotations
Bilal Elmoussaoui [Tue, 24 Nov 2020 17:08:31 +0000 (18:08 +0100)]
TextView: add missing nullability annotations
Bilal Elmoussaoui [Tue, 24 Nov 2020 17:04:34 +0000 (18:04 +0100)]
TreeModel: add missing nullability annotations
Bilal Elmoussaoui [Tue, 24 Nov 2020 16:57:32 +0000 (17:57 +0100)]
TreeView: add missing nullability annotations
Matthias Clasen [Wed, 2 Dec 2020 15:08:58 +0000 (10:08 -0500)]
widget: Add a missing nullability annotation
Matthias Clasen [Wed, 2 Dec 2020 15:06:01 +0000 (10:06 -0500)]
Clarify the docs for gtk_widget_class_set_css_name
Reword, and mention the default css name.
Bilal Elmoussaoui [Tue, 24 Nov 2020 16:35:46 +0000 (17:35 +0100)]
window: default_icon_name can be null
Emmanuele Bassi [Wed, 2 Dec 2020 13:40:25 +0000 (13:40 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Various documentation fixes
See merge request GNOME/gtk!2900
Daniel Mustieles [Wed, 2 Dec 2020 12:54:32 +0000 (13:54 +0100)]
Updated Spanish translation
Daniel Mustieles [Wed, 2 Dec 2020 08:26:08 +0000 (09:26 +0100)]
Updated Spanish translation